dbatomic commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1512869445
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -597,4 +597,49 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHelper {
})
})
}
+
+ test("inner join respects collations") {
Review Comment:
It's same. Having this test may come in handy while developing hash based
joins, given that it's easier to debug functional tests then golden files.
But if you feel that it is redundant I can remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
