panbingkun commented on code in PR #45368:
URL: https://github.com/apache/spark/pull/45368#discussion_r1513941395
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -156,15 +156,6 @@ class V2SessionCatalog(catalog: SessionCatalog)
columns: Array[Column],
partitions: Array[Transform],
properties: util.Map[String, String]): Table = {
- createTable(ident, CatalogV2Util.v2ColumnsToStructType(columns),
partitions, properties)
- }
-
- // TODO: remove it when no tests calling this deprecated method.
- override def createTable(
Review Comment:
I will move the specific implementation of createTable from
`createTable(..., StructType, ...)` to `createTable(..., Array[Column], ...)`,
so that when we delete the deprecated method `createTable(..., StructType,
...)` in `TableCatalog`, we can directly delete the method `createTable(...,
StructType, ...)` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
