panbingkun commented on code in PR #45368:
URL: https://github.com/apache/spark/pull/45368#discussion_r1514278795
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala:
##########
@@ -84,28 +84,29 @@ class BasicInMemoryTableCatalog extends TableCatalog {
invalidatedTables.add(ident)
}
- // TODO: remove it when no tests calling this deprecated method.
+ // TODO: remove it when the deprecated method `createTable(..., StructType,
...)`
Review Comment:
If we want to delete this now, then we need to remove the method
`TableCatalog#createTable(..., StructType, ...)`,
I am a bit worried that although `TableCatalog` is marked with `@Evolving`,
third parties (eg: iceberg) relying on this interface will immediately feel the
`break changes`, such as:
https://github.com/apache/iceberg/blob/f0b3733e0e7071894bdf63133bcc8c00754a1080/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java#L172-L182
<img width="794" alt="image"
src="https://github.com/apache/spark/assets/15246973/520f942a-d113-4575-ab61-d9ec38b3b4aa";>
Do we really need to do this now?
At present, Spark can indeed directly delete it internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
