MaxGekk commented on code in PR #45405:
URL: https://github.com/apache/spark/pull/45405#discussion_r1516373801
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1096,7 +1096,7 @@ colPosition
;
collateClause
- : COLLATE collationName=stringLit
+ : COLLATE collationName=identifier
Review Comment:
Let's look at the examples:
```
spark-sql (default)> select 'aaa' collate test_collation;
[COLLATION_INVALID_NAME] The value test_collation does not represent a
correct collation name. Suggested valid collation name: [UCS_BASIC]. SQLSTATE:
42704
```
The error message says about `test_collation`, that's correct but:
```
spark-sql (default)> select 'aaa' collate test-collation;
[COLLATION_INVALID_NAME] The value test does not represent a correct
collation name. Suggested valid collation name: [UNICODE]. SQLSTATE: 42704
```
it points out `test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
