MaxGekk commented on code in PR #45405:
URL: https://github.com/apache/spark/pull/45405#discussion_r1516378011
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1096,7 +1096,7 @@ colPosition
;
collateClause
- : COLLATE collationName=stringLit
+ : COLLATE collationName=identifier
Review Comment:
BTW, I would improve the error message to:
```
[COLLATION_INVALID_NAME] `test_collation` does not represent a correct
collation name. Suggested valid collation name: UCS_BASIC. SQLSTATE: 42704
```
and attach a query context like in:
```
spark-sql (default)> select 'aaa' from test-table;
[INVALID_IDENTIFIER] The identifier test-table is invalid. Please, consider
quoting it with back-quotes as `test-table`. SQLSTATE: 42602 (line 1, pos 22)
== SQL ==
select 'aaa' from test-table
----------------------^^^
```
@dbatomic Could you open an JIRA for that, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
