johnnywalker commented on code in PR #45410:
URL: https://github.com/apache/spark/pull/45410#discussion_r1516375276
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala:
##########
@@ -153,12 +153,12 @@ object JDBCRDD extends Logging {
*/
class JDBCRDD(
Review Comment:
@HyukjinKwon Thanks for pointing out the binary compatibility problem. I
tried using `dev/mima`, but MiMa was unable to instrument `JDBCRDD`.
How do we fix this issue without breaking compatibility? It looks like the
last change to the parameter list was here:
https://github.com/apache/spark/commit/4ad7386eefe0856e500d1a11e2bb992a045ff217#diff-ecf5b374060c1222d3a0a1295b4ec2cb5d07603db460273484b1753e1cab9f90R173.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
