utkarshwealthy commented on code in PR #45410:
URL: https://github.com/apache/spark/pull/45410#discussion_r1518645531
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala:
##########
@@ -153,12 +153,12 @@ object JDBCRDD extends Logging {
*/
class JDBCRDD(
Review Comment:
@johnnywalker @HyukjinKwon
To address this concern, I propose an alternative approach to achieve the
desired behavior without modifying the public API of the class. Instead of
changing the constructor signature, we can introduce an internal method within
the class, specifically for binding the resolved dialect. This method can be
called in the Spark driver after the dialect resolution, ensuring that the
dialect is explicitly bound to the RDD.
This approach maintains the existing constructor signature intact while
providing a means to set the resolved dialect internally. The method can be
invoked within the Spark driver after the dialect is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
