mridulm commented on code in PR #45425:
URL: https://github.com/apache/spark/pull/45425#discussion_r1525231740


##########
common/network-common/src/main/java/org/apache/spark/network/crypto/README.md:
##########
@@ -1,6 +1,20 @@
-Forward Secure Auth Protocol
+Forward Secure Auth Protocol v1.1
 ==============================================
 
+Deprecation Notice
+------------------
+This is a bespoke key exchange protocol that was implemented before Spark 
supported TLS (aka SSL) for RPC
+calls. It is recommended that Spark users upgrade to using TLS for RPC calls 
between Spark processes. This protocol
+will be deprecated and removed in the long-term.
+
+See
+the [Spark security 
documentation](https://github.com/apache/spark/blob/master/docs/security.md#ssl-encryption)
 for
+more information on how to configure TLS.

Review Comment:
   I am not sure if we should announce deprecation given TLS is going to come 
out only in 4.0 ... we can recommend users to move to TLS.
   
   Would like feedback from others on this though ... @dongjoon-hyun, @srowen, 
@JoshRosen 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to