dbatomic commented on code in PR #45563:
URL: https://github.com/apache/spark/pull/45563#discussion_r1528750342
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala:
##########
@@ -2821,4 +2821,88 @@ class CollectionExpressionsSuite
a, Literal(5), Literal.create("q", StringType)), Seq("b", "a", "c",
null, "q")
)
}
+
+ test("Array operations on arrays of collated strings") {
Review Comment:
IMO, golden file tests already cover most of these cases.
Secondly, general agreement is to keep collation tests grouping in either
CollationSuite or CollationExpressionSuite. Let's keep it that way.
Besides that LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
