cloud-fan commented on code in PR #45563:
URL: https://github.com/apache/spark/pull/45563#discussion_r1528757747


##########
sql/core/src/test/resources/sql-tests/inputs/collations.sql:
##########
@@ -70,3 +70,29 @@ select array_position(ARRAY('aaa' collate utf8_binary_lcase, 
'bbb' collate utf8_
 -- utility
 select nullif('aaa' COLLATE utf8_binary_lcase, 'AAA' COLLATE 
utf8_binary_lcase);
 select least('aaa' COLLATE utf8_binary_lcase, 'AAA' collate utf8_binary_lcase, 
'a' collate utf8_binary_lcase);
+
+-- array operations
+select arrays_overlap(array('aaa' collate utf8_binary_lcase), array('AAA' 
collate utf8_binary_lcase));

Review Comment:
   +1, we should write scala unit tests for test coverage. end-to-end is mostly 
testing the integration part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to