dbatomic commented on code in PR #45592: URL: https://github.com/apache/spark/pull/45592#discussion_r1530431684
########## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ########## @@ -109,7 +109,7 @@ public Collation( private static final Collation[] collationTable = new Collation[4]; private static final HashMap<String, Integer> collationNameToIdMap = new HashMap<>(); - public static final int DEFAULT_COLLATION_ID = 0; + public static final int SPARK_INTERNAL_COLLATION_ID = 0; Review Comment: Can you call this simply `UTF8_BINARY_COLLATION_ID`? I think adding any other adjective will only bring confusion (what does `INTERNAL` mean?). Also, please rename `LOWERCASE_COLLATION_ID`. It should be `UTF_BINARY_LCASE_COLLATION_ID`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
