dbatomic commented on code in PR #45592:
URL: https://github.com/apache/spark/pull/45592#discussion_r1530435638
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -31,7 +32,8 @@ class StringType private(val collationId: Int) extends
AtomicType with Serializa
/**
* Returns whether assigned collation is the default spark collation
(UTF8_BINARY).
*/
- def isDefaultCollation: Boolean = collationId ==
CollationFactory.DEFAULT_COLLATION_ID
+ def isDefaultCollation: Boolean =
Review Comment:
My fear is that this may be perf sensitive place. can you keep this as
simple int compare? `collationNameToId` is dictionary search against string
field...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
