stefankandic commented on code in PR #45615:
URL: https://github.com/apache/spark/pull/45615#discussion_r1532420069
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##########
@@ -70,6 +70,34 @@ class CollationStringExpressionsSuite extends QueryTest with
SharedSparkSession
})
}
+ case class RepeatCollationTestCase[R](s: String, n: Int, collation: String,
expectedResult: R)
+
+ test("Support Repeat string expression with Collation") {
+ // Supported collations
+ val checksRepeat = Seq(
+ RepeatCollationTestCase("Spark", 2, "UTF8_BINARY", "SparkSpark"),
Review Comment:
i see that you're just doing the same thing as the previous test but I'm not
a fan of creating a class for each test
something i would recommend would be:
```
checksRepeat.foreach { case (s, n, collation, expectedResult) =>
...
}
```
but this is not a big deal, so it's up to you whichever you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
