miland-db commented on code in PR #45615:
URL: https://github.com/apache/spark/pull/45615#discussion_r1537382204
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##########
@@ -70,6 +73,19 @@ class CollationStringExpressionsSuite extends QueryTest with
SharedSparkSession
})
}
+ test("REPEAT check output type on explicitly collated string") {
+ def testRepeat(expected: String, stringType: Integer, input: String, n:
Integer): Unit = {
+ val s = Literal.create(input, StringType(stringType))
+
+ checkEvaluation(Collation(StringRepeat(s,
Literal.create(n))).replacement, expected)
Review Comment:
Yes, I test if the output type matches the expected result. You can see
below that I test if the result has type for example `expected="UNICODE_CI"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
