dongjoon-hyun commented on code in PR #45488:
URL: https://github.com/apache/spark/pull/45488#discussion_r1534110561


##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:
##########
@@ -583,6 +611,24 @@ case class MyParser(spark: SparkSession, delegate: 
ParserInterface) extends Pars
     delegate.parseQuery(sqlText)
 }
 
+case class AddTagRule() extends Rule[SparkPlan] {

Review Comment:
   `AddTagRule` looks too general in a long term perspective. Shall we use more 
specific one like `ExplainPlanInfoTagRule`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to