dongjoon-hyun commented on code in PR #45488:
URL: https://github.com/apache/spark/pull/45488#discussion_r1534127854
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##########
@@ -464,6 +464,60 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
s"($opId) $nodeName$codegenId"
}
+ def extensionsInfo(mode: String = "simple"): String = {
Review Comment:
Shall we use `enum` instead of `String` type? For me, the following code in
test suite looks fragile and error-prone.
```scala
val info = df.queryExecution.executedPlan.extensionsInfo("extended")
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##########
@@ -464,6 +464,60 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
s"($opId) $nodeName$codegenId"
}
+ def extensionsInfo(mode: String = "simple"): String = {
Review Comment:
Shall we use `enum` instead of `String` type? For me, the following code in
test suite looks fragile and error-prone due to the typos.
```scala
val info = df.queryExecution.executedPlan.extensionsInfo("extended")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
