dongjoon-hyun commented on code in PR #45666:
URL: https://github.com/apache/spark/pull/45666#discussion_r1535823668
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -938,9 +938,17 @@ class JDBCSuite extends QueryTest with SharedSparkSession {
Some(BooleanType))
assert(mySqlDialect.getCatalystType(java.sql.Types.TINYINT, "TINYINT", 1,
metadata) ==
Some(ByteType))
+ assert(mySqlDialect.getCatalystType(java.sql.Types.REAL, "FLOAT", 1,
metadata) ===
+ Some(FloatType))
+ assert(mySqlDialect.getCatalystType(java.sql.Types.FLOAT, "FLOAT", 1,
metadata) ===
+ Some(FloatType))
metadata.putBoolean("isSigned", value = false)
assert(mySqlDialect.getCatalystType(java.sql.Types.TINYINT, "TINYINT", 1,
metadata) ===
Some(ShortType))
+ assert(mySqlDialect.getCatalystType(java.sql.Types.REAL, "FLOAT", 1,
metadata) ===
+ Some(DoubleType))
+ assert(mySqlDialect.getCatalystType(java.sql.Types.FLOAT, "FLOAT", 1,
metadata) ===
+ Some(DoubleType))
Review Comment:
Just for my understanding, if we use the following, do you know when
`DOUBLE` is required?
https://dev.mysql.com/doc/refman/8.3/en/floating-point-types.html
> FLOAT[(M,D)] [UNSIGNED] [ZEROFILL]
- A small (single-precision) floating-point number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
