yaooqinn commented on code in PR #45666:
URL: https://github.com/apache/spark/pull/45666#discussion_r1536002553
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala:
##########
@@ -123,6 +123,8 @@ private case class MySQLDialect() extends JdbcDialect with
SQLConfHelper {
// Signed values in [-8388608, 8388607] and unsigned values in [0,
16777215],
// both of them fit IntegerType
Some(IntegerType)
+ case Types.REAL | Types.FLOAT =>
+ if (md.build().getBoolean("isSigned")) Some(FloatType) else
Some(DoubleType)
Review Comment:
Hi @dongjoon-hyun. Yes, it's safe, we get `isSigned` from the JDBC standard
API. It's OK for the DB side to remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
