mihailom-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1537909524
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##########
@@ -70,6 +73,46 @@ class CollationStringExpressionsSuite extends QueryTest with
SharedSparkSession
})
}
+ test("REPLACE check result on explicitly collated strings") {
+ def testReplace(expected: String, collationId: Integer,
+ source: String, search: String, replace: String): Unit = {
Review Comment:
nit, ordering of parameters seem a bit non-intuitive (expected before inputs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
