uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1546514048


##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -1136,6 +1136,57 @@ public UTF8String replace(UTF8String search, UTF8String 
replace) {
     return buf.build();
   }
 
+  public UTF8String replace(UTF8String search, UTF8String replace, int 
collationId) {
+    if (CollationFactory.fetchCollation(collationId).supportsBinaryEquality) {
+      return this.replace(search, replace);
+    }
+    return collatedReplace(search, replace, collationId);
+  }
+
+  private UTF8String collatedReplace(UTF8String search, UTF8String replace, 
int collationId) {

Review Comment:
   Let's go with this naming: `collationAwareReplace`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to