chenhao-db commented on PR #45708: URL: https://github.com/apache/spark/pull/45708#issuecomment-2019117063
@cloud-fan I haven't changed https://github.com/apache/spark/pull/45708/files#diff-9e7a4d9777eb424f4453b1ece9618eb916ea4b1e312d5e300b1b29b657ced562R305. There are two reasons: - Although we should never hit this error inside Spark, the variant sub-libaray is intended to be used outside of Spark too, and other users may hit it (e.g., call `getLong` without ensuring `getType` is `LONG`). So it shouldn't be an internal error. - Throwing a `SparkException` requires changing all the Java method signatures that use this function, which is a non-trivial change. Please let me know whether it makes sense. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
