dongjoon-hyun commented on code in PR #45703:
URL: https://github.com/apache/spark/pull/45703#discussion_r1539468054
##########
sql/core/src/test/scala/org/apache/spark/sql/VariantSuite.scala:
##########
@@ -192,4 +192,48 @@ class VariantSuite extends QueryTest with
SharedSparkSession {
}
}
}
+
+ test("invalid variant binary") {
+ // Write a struct-of-binary that looks like a Variant, but with minor
variations that may make
+ // it invalid to read.
+ // Test cases:
+ // 1) A binary that has the correct parquet structure for Variant.
+ // 2) A binary that has the correct parquet structure in unexpected order.
This is valid.
Review Comment:
Please remove (1) and (2) from this test case. It doesn't match with the
test case name and the above description.
> // Write a struct-of-binary that looks like a Variant, but with minor
variations that may make
> // it invalid to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
