cashmand commented on code in PR #45703:
URL: https://github.com/apache/spark/pull/45703#discussion_r1539484303
##########
sql/core/src/test/scala/org/apache/spark/sql/VariantSuite.scala:
##########
@@ -192,4 +192,48 @@ class VariantSuite extends QueryTest with
SharedSparkSession {
}
}
}
+
+ test("invalid variant binary") {
+ // Write a struct-of-binary that looks like a Variant, but with minor
variations that may make
+ // it invalid to read.
+ // Test cases:
+ // 1) A binary that has the correct parquet structure for Variant.
+ // 2) A binary that has the correct parquet structure in unexpected order.
This is valid.
Review Comment:
I'd like to leave them in some form, as as sanity check that we can
successfully read the values when they're in the right format, since manually
constructing these binary values isn't the normal way to create a Variant, and
I want to make sure that the other test cases are failing because of the
variations from this working case, and not because the working case itself is
broken for some reason.
I could add a comment to clarify this, or move these two into a separate
test. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
