miland-db commented on PR #45725: URL: https://github.com/apache/spark/pull/45725#issuecomment-2022319005
I am testing functions from `stringExpressions`. Existing tests for these functions on non-collated strings are written in `StringExpressionsSuite`. Following that logic test on collated strings using functions from `stringExpressions` should be in `CollationStringExpressionsSuite`. I can add unit tests for changes introduced in `UTF8String` to `UTF8StringWithCollationSuite.java` if that's what we want to test that part more thoroughly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
