stefankandic commented on code in PR #45725:
URL: https://github.com/apache/spark/pull/45725#discussion_r1544722450
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -913,6 +1028,57 @@ public UTF8String subStringIndex(UTF8String delim, int
count) {
}
}
+ public UTF8String subStringIndex(UTF8String delim, int count, int
collationId) {
+ if (CollationFactory.fetchCollation(collationId).supportsBinaryEquality) {
Review Comment:
aren't we already checking for this when we do codegen? This way we're
losing the benefit of not having to worry about branching for the codegen path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
