uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1549420147
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -1136,6 +1136,56 @@ public UTF8String replace(UTF8String search, UTF8String
replace) {
return buf.build();
}
+ public UTF8String replace(UTF8String search, UTF8String replace, int
collationId) {
Review Comment:
I think we now have a lot of new methods
consider adding comments such as:
https://github.com/apache/spark/pull/45791/files#r1549415554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
