cloud-fan commented on code in PR #45383: URL: https://github.com/apache/spark/pull/45383#discussion_r1546551263
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala: ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import javax.annotation.Nullable + +import scala.annotation.tailrec + +import org.apache.spark.sql.catalyst.analysis.TypeCoercion.hasStringType +import org.apache.spark.sql.catalyst.expressions.{BinaryExpression, Cast, ComplexTypeMergingExpression, CreateArray, ExpectsInputTypes, Expression, Predicate, SortOrder} +import org.apache.spark.sql.errors.QueryCompilationErrors +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.sql.types.{AbstractDataType, ArrayType, DataType, StringType} + +object CollationTypeCasts extends TypeCoercionRule { + override val transform: PartialFunction[Expression, Expression] = { + case e if !e.childrenResolved => e + case sc @ (_: BinaryExpression + | _: Predicate + | _: SortOrder + | _: ExpectsInputTypes + | _: ComplexTypeMergingExpression) => + val newChildren = collateToSingleType(sc.children) + sc.withNewChildren(newChildren) + case pesc @ (_: CreateArray) => Review Comment: The example query is `SELECT array('a', 'b' collate UNICODE) || ('c' collate UNICODE_CI)`. This is kind of artificial as users can write one `array(...)` function, but think about a rewrite like `SELECT arr || ('c' collate UNICODE_CI) FROM (SELECT array('a', 'b' collate UNICODE) as arr)`, I think returning an array with string of collation UNICODE_CI is fine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
