cloud-fan commented on code in PR #45383:
URL: https://github.com/apache/spark/pull/45383#discussion_r1547197835
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##########
@@ -702,26 +707,39 @@ abstract class TypeCoercionBase {
}.getOrElse(b) // If there is no applicable conversion, leave
expression unchanged.
case e: ImplicitCastInputTypes if e.inputTypes.nonEmpty =>
- val children: Seq[Expression] = e.children.zip(e.inputTypes).map {
case (in, expected) =>
+ val childrenBeforeCollations: Seq[Expression] =
e.children.zip(e.inputTypes).map {
// If we cannot do the implicit cast, just use the original input.
- implicitCast(in, expected).getOrElse(in)
+ case (in, expected) => implicitCast(in, expected).getOrElse(in)
+ }
+ val st = getOutputCollation(e.children)
+ val children: Seq[Expression] = childrenBeforeCollations.map {
Review Comment:
what are we doing here? `ImplicitCastInputTypes` defines the expected data
type of each input, but does not require all inputs to be the same data type.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##########
@@ -702,26 +707,39 @@ abstract class TypeCoercionBase {
}.getOrElse(b) // If there is no applicable conversion, leave
expression unchanged.
case e: ImplicitCastInputTypes if e.inputTypes.nonEmpty =>
- val children: Seq[Expression] = e.children.zip(e.inputTypes).map {
case (in, expected) =>
+ val childrenBeforeCollations: Seq[Expression] =
e.children.zip(e.inputTypes).map {
// If we cannot do the implicit cast, just use the original input.
- implicitCast(in, expected).getOrElse(in)
+ case (in, expected) => implicitCast(in, expected).getOrElse(in)
+ }
+ val st = getOutputCollation(e.children)
+ val children: Seq[Expression] = childrenBeforeCollations.map {
+ case in if hasStringType(in.dataType) =>
+ castStringType(in, st).getOrElse(in)
+ case in => in
}
e.withNewChildren(children)
case e: ExpectsInputTypes if e.inputTypes.nonEmpty =>
// Convert NullType into some specific target type for
ExpectsInputTypes that don't do
// general implicit casting.
- val children: Seq[Expression] = e.children.zip(e.inputTypes).map {
case (in, expected) =>
+ val childrenBeforeCollations: Seq[Expression] =
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
