sahnib commented on code in PR #45674:
URL: https://github.com/apache/spark/pull/45674#discussion_r1547140114
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -77,14 +78,23 @@ class StatefulProcessorHandleImpl(
store: StateStore,
runId: UUID,
keyEncoder: ExpressionEncoder[Any],
+ ttlMode: TTLMode,
timeoutMode: TimeoutMode,
- isStreaming: Boolean = true)
+ isStreaming: Boolean = true,
+ batchTimestampMs: Option[Long] = None,
+ eventTimeWatermarkMs: Option[Long] = None)
extends StatefulProcessorHandle with Logging {
import StatefulProcessorHandleState._
+ /**
+ * Stores all the active ttl states, and is used to cleanup expired values
+ * in [[doTtlCleanup()]] function.
+ */
+ private val ttlStates: util.List[TTLState] = new util.ArrayList[TTLState]()
Review Comment:
I dont think there is a usecase to access ttl state by name. We can modify
it in future if needed.
I dont think this needs to be thread safe, as all access happens only in
Task thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
