anishshri-db commented on code in PR #45674: URL: https://github.com/apache/spark/pull/45674#discussion_r1547183958
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StateTypesEncoderUtils.scala: ########## @@ -49,12 +54,17 @@ object StateKeyValueRowSchema { class StateTypesEncoder[GK, V]( keySerializer: Serializer[GK], valEncoder: Encoder[V], - stateName: String) { - import org.apache.spark.sql.execution.streaming.StateKeyValueRowSchema._ + stateName: String, + hasTtl: Boolean) extends Logging { + import org.apache.spark.sql.execution.streaming.TransformWithStateKeyValueRowSchema._ /** Variables reused for conversions between byte array and UnsafeRow */ private val keyProjection = UnsafeProjection.create(KEY_ROW_SCHEMA) - private val valueProjection = UnsafeProjection.create(VALUE_ROW_SCHEMA) + private val valueProjection = if (hasTtl) { + UnsafeProjection.create(VALUE_ROW_SCHEMA_WITH_TTL) Review Comment: Hmm - maybe its just a GH UI thing - but it appears like 4 spaces to me ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org