kelvinjian-db commented on code in PR #45871:
URL: https://github.com/apache/spark/pull/45871#discussion_r1551055920
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3390,13 +3390,13 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
- val REPLACE_NULLIF_USING_WITH_EXPR =
- buildConf("spark.databricks.sql.replaceNullIfUsingWithExpr")
+ val ALWAYS_INLINE_COMMON_EXPR_IN_WITH =
+ buildConf("spark.sql.alwaysInlineCommonExprInWith")
.internal()
- .doc("When true, NullIf expressions are rewritten using With expressions
to avoid " +
- "expression duplication.")
+ .doc("When true, always inline common expressions inside WITH expression
which may lead " +
Review Comment:
when this config is true, we don't inline the common expressions IN the
`With` expression, rather we just inline the common expressions? should we
remove "inside WITH expression"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
