cloud-fan commented on code in PR #45871:
URL: https://github.com/apache/spark/pull/45871#discussion_r1552674823
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3390,13 +3390,14 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
- val REPLACE_NULLIF_USING_WITH_EXPR =
- buildConf("spark.databricks.sql.replaceNullIfUsingWithExpr")
+ val ALWAYS_INLINE_COMMON_EXPR =
+ buildConf("spark.sql.alwaysInlineCommonExpr")
.internal()
- .doc("When true, NullIf expressions are rewritten using With expressions
to avoid " +
- "expression duplication.")
+ .doc("When true, always inline common expressions instead of using the
WITH expression. " +
+ "This may lead to duplicated expressions and the config should only be
enabled if you " +
+ "hit bugs caused by the WITH expression.")
.booleanConf
Review Comment:
```suggestion
.version("4.0.0")
.booleanConf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
