sahnib commented on code in PR #45674:
URL: https://github.com/apache/spark/pull/45674#discussion_r1552897542
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StateTypesEncoderUtils.scala:
##########
@@ -65,22 +74,48 @@ class StateTypesEncoder[GK, V](
// TODO: validate places that are trying to encode the key and check if we
can eliminate/
// add caching for some of these calls.
def encodeGroupingKey(): UnsafeRow = {
+ val keyRow = keyProjection(InternalRow(serializeGroupingKey()))
+ keyRow
+ }
+
+ /**
+ * Encodes the provided grouping key into Spark UnsafeRow.
+ *
+ * @param groupingKeyBytes serialized grouping key byte array
+ * @return encoded UnsafeRow
+ */
+ def encodeSerializedGroupingKey(groupingKeyBytes: Array[Byte]): UnsafeRow = {
+ val keyRow = keyProjection(InternalRow(groupingKeyBytes))
+ keyRow
+ }
+
+ def serializeGroupingKey(): Array[Byte] = {
val keyOption = ImplicitGroupingKeyTracker.getImplicitKeyOption
if (keyOption.isEmpty) {
throw StateStoreErrors.implicitKeyNotFound(stateName)
}
-
val groupingKey = keyOption.get.asInstanceOf[GK]
- val keyByteArr =
keySerializer.apply(groupingKey).asInstanceOf[UnsafeRow].getBytes()
- val keyRow = keyProjection(InternalRow(keyByteArr))
- keyRow
+ keySerializer.apply(groupingKey).asInstanceOf[UnsafeRow].getBytes()
}
+ /**
+ * Encode the specified value in Spark UnsafeRow with no ttl.
+ * The ttl expiration will be set to -1, specifying no TTL.
+ */
def encodeValue(value: V): UnsafeRow = {
Review Comment:
The comment is outdated. I have removed it from here. Also, we do not need a
default value for `expirationMs: Long` anymore. Its the whole reason I split it
into 2 methods. Not sure why Scala compiler did not catch this. I have removed
the default value from second parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
