sahnib commented on code in PR #45674:
URL: https://github.com/apache/spark/pull/45674#discussion_r1554101379
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulProcessorHandleSuite.scala:
##########
@@ -227,19 +218,17 @@ class StatefulProcessorHandleSuite extends
StateVariableSuiteBase {
}
}
- Seq("ProcessingTime", "EventTime").foreach { ttlMode =>
- test(s"ttl States are populated for ttlMode=$ttlMode") {
- tryWithProviderResource(newStoreProviderWithStateVariable(true)) {
provider =>
- val store = provider.getStore(0)
- val handle = new StatefulProcessorHandleImpl(store,
- UUID.randomUUID(), keyExprEncoder, getTtlMode(ttlMode),
TimeoutMode.NoTimeouts(),
- batchTimestampMs = Some(10), eventTimeWatermarkMs = Some(100))
+ test(s"ttl States are populated for ttlMode=ProcessingTime") {
+ tryWithProviderResource(newStoreProviderWithStateVariable(true)) {
provider =>
+ val store = provider.getStore(0)
+ val handle = new StatefulProcessorHandleImpl(store,
+ UUID.randomUUID(), keyExprEncoder, TTLMode.ProcessingTimeTTL(),
TimeoutMode.NoTimeouts(),
+ batchTimestampMs = Some(10))
- val valueState = handle.getValueState("testState", Encoders.STRING)
+ val valueState = handle.getValueState("testState", Encoders.STRING)
Review Comment:
It would not be, I have captured both scenarios in the test now (created a
ttl and non-ttl state).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
