panbingkun commented on code in PR #45890:
URL: https://github.com/apache/spark/pull/45890#discussion_r1553572638
##########
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##########
@@ -33,40 +34,56 @@ object LogKey extends Enumeration {
val CLASS_NAME = Value
val COMMAND = Value
val COMMAND_OUTPUT = Value
+ val COMPONENT = Value
val CONFIG = Value
val CONFIG2 = Value
val CONTAINER_ID = Value
val COUNT = Value
val DRIVER_ID = Value
+ val END_POINT = Value
val ERROR = Value
+ val EVENT_LOOP = Value
val EVENT_QUEUE = Value
val EXECUTOR_ID = Value
val EXECUTOR_STATE_CHANGED = Value
val EXIT_CODE = Value
+ val FAILURES = Value
val HOST = Value
val JOB_ID = Value
val LEARNING_RATE = Value
val LINE = Value
val LINE_NUM = Value
+ val LISTENER = Value
+ val LOG_TYPE = Value
val MASTER_URL = Value
val MAX_ATTEMPTS = Value
val MAX_CATEGORIES = Value
val MAX_EXECUTOR_FAILURES = Value
val MAX_SIZE = Value
+ val MERGE_DIR_NAME = Value
+ val METHOD_NAME = Value
val MIN_SIZE = Value
val NUM_ITERATIONS = Value
+ val OBJECT_ID = Value
val OLD_BLOCK_MANAGER_ID = Value
val OPTIMIZER_CLASS_NAME = Value
val PARTITION_ID = Value
val PATH = Value
+ val PATHS = Value
val POD_ID = Value
+ val PORT = Value
val RANGE = Value
+ val RDD_ID = Value
val REASON = Value
+ val REDUCE_ID = Value
val REMOTE_ADDRESS = Value
val RETRY_COUNT = Value
val RPC_ADDRESS = Value
+ val SHUFFLE_BLOCK_INFO = Value
val SHUFFLE_ID = Value
+ val SHUFFLE_MERGE_ID = Value
val SIZE = Value
+ val SLEEP_TIME_SECONDS = Value
Review Comment:
Do we need the suffix `_SECONDS`?
Will we encounter `SLEEP_TIME_MILLISECONDS` like this in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
