panbingkun commented on code in PR #45890:
URL: https://github.com/apache/spark/pull/45890#discussion_r1553632106
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -661,9 +661,10 @@ private[spark] class Executor(
// uh-oh. it appears the user code has caught the fetch-failure
without throwing any
// other exceptions. Its *possible* this is what the user meant to
do (though highly
// unlikely). So we will log an error and keep going.
- logError(s"$taskName completed successfully though internally it
encountered " +
- s"unrecoverable fetch failures! Most likely this means user code
is incorrectly " +
- s"swallowing Spark's internal ${classOf[FetchFailedException]}",
fetchFailure)
+ logError(log"${LogMDC(TASK_NAME, taskName)} completed successfully
though internally " +
+ log"it encountered unrecoverable fetch failures! Most likely this
means user code " +
Review Comment:
Can we correct the original appearance of the two whitespaces before `Most`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
