uros-db commented on code in PR #45738:
URL: https://github.com/apache/spark/pull/45738#discussion_r1555227674
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##########
@@ -86,6 +89,43 @@ class CollationStringExpressionsSuite extends QueryTest
testRepeat("UNICODE_CI", 3, "abc", 2)
}
+ test("substring check output type on explicitly collated string") {
Review Comment:
yeah, let's put all these tests that are specific to string functions into
the separate suite `CollationStringExpressionsSuite`
this way, `CollationSuite` won't get cluttered as we continue adding more
and more support for various string expressions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
