itholic commented on code in PR #45377:
URL: https://github.com/apache/spark/pull/45377#discussion_r1555359203
##########
sql/core/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -699,6 +699,13 @@ class Column(val expr: Expression) extends Logging {
*/
def plus(other: Any): Column = this + other
+ def plusWithPySparkLoggingInfo(
+ other: Any, loggingInfo: java.util.Map[String, String]): Column = {
+ withOrigin(Some(loggingInfo)) {
+ this + other
+ }
+ }
Review Comment:
Hi, @cloud-fan I added these kind of new `Column` expression methods for
taking Python call site information properly along with extending the
implementation of the existing `Origin` and `WithOrigin`.
Thanks for your suggestion, now the call site correctness problem seems to
be resolved, but I'm wondering if these `{name}PySparkLoggingInfo` methods
should be added to all each `Coulmn` APIs.
As this design can be changed after the review, I added for only four
functions - `plus`, `divide`, `minus`, and `multiply` - as a prototype for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
