cloud-fan commented on code in PR #45377:
URL: https://github.com/apache/spark/pull/45377#discussion_r1555465767
##########
sql/core/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -699,6 +699,13 @@ class Column(val expr: Expression) extends Logging {
*/
def plus(other: Any): Column = this + other
+ def plusWithPySparkLoggingInfo(
+ other: Any, loggingInfo: java.util.Map[String, String]): Column = {
+ withOrigin(Some(loggingInfo)) {
+ this + other
+ }
+ }
Review Comment:
This is too much work... Ideally all column creation APIs call `Column.fn`
at the end, if we can change pyspark code to only call the Scala `Column.fn`,
then we don't need to change the Scala side too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
