cloud-fan commented on code in PR #45945:
URL: https://github.com/apache/spark/pull/45945#discussion_r1557628324


##########
common/variant/src/main/java/org/apache/spark/types/variant/Variant.java:
##########
@@ -89,6 +97,37 @@ public BigDecimal getDecimal() {
     return VariantUtil.getDecimal(value, pos);
   }
 
+  // Get a raw date value (number of days from the Unix epoch) from the 
variant.
+  public int getRawDate() {

Review Comment:
   do we need to have these methods? date/timestamp are logical types and are 
physically int/long. We just need the metadata to indicate them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to