chenhao-db commented on code in PR #45945:
URL: https://github.com/apache/spark/pull/45945#discussion_r1559545416
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala:
##########
@@ -248,9 +253,10 @@ case object VariantGet {
input: VariantVal,
dataType: DataType,
failOnError: Boolean,
- zoneId: Option[String]): Any = {
+ zoneStr: Option[String],
Review Comment:
The zone id string is needed to construct the `Cast` object. It can also be
obtained from `zoneId` (`zoneStr == Some(zoneId.getId)`), but that would
require more runtime cost than passing both the string and the id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
