cloud-fan commented on code in PR #45739:
URL: https://github.com/apache/spark/pull/45739#discussion_r1557677008
##########
sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala:
##########
@@ -34,7 +34,7 @@ trait TPCDSBase extends TPCBase with TPCDSSchema {
"q81", "q82", "q83", "q84", "q85", "q86", "q87", "q88", "q89", "q90",
"q91", "q92", "q93", "q94", "q95", "q96", "q97", "q98", "q99")
- protected val excludedTpcdsQueries: Set[String] = if (regenerateGoldenFiles)
{
+ protected def excludedTpcdsQueries: Set[String] = if (regenerateGoldenFiles)
{
Review Comment:
It's used in a loop and shouldn't be `def`. BTW `val` can be overridden in
scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
