cloud-fan commented on code in PR #45946:
URL: https://github.com/apache/spark/pull/45946#discussion_r1560342794
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -1062,4 +1062,11 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHelper {
checkAnswer(dfNonBinary, dfBinary)
}
}
+
+ test("SPARK-47765: test SET COLLATION statement") {
Review Comment:
I'm looking at how we test `SET TIMEZONE`. It's in `SQLConfSuite`. I feel
it's a better way of testing as we are making tests orthogonal. We need to make
sure `SET COLLATION` sets the expected conf correctly, and we already have test
in this suite to make sure the default collation config works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
