mihailom-db commented on code in PR #45946:
URL: https://github.com/apache/spark/pull/45946#discussion_r1561024421


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -772,6 +772,8 @@ object SQLConf {
         " produced by a builtin function such as to_char or CAST")
       .version("4.0.0")
       .stringConf
+      .checkValue(CollationFactory.collationNameToId(_) >= 0,

Review Comment:
   The reason why I left it as it is, is that we give suggestion for close 
name. I am not sure how would we pass the suggestion if done here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to