panbingkun commented on code in PR #46057:
URL: https://github.com/apache/spark/pull/46057#discussion_r1568270967
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousTextSocketSource.scala:
##########
@@ -179,7 +180,7 @@ class TextSocketContinuousStream(
val line = reader.readLine()
if (line == null) {
// End of file reached
- logWarning(s"Stream closed by $host:$port")
+ logWarning(log"Stream closed by ${MDC(HOST, host)}:${MDC(PORT,
port)}")
Review Comment:
If we use `HOST_PORT`, then it will be,
```
logWarning(log"Stream closed by ${MDC(HOST_PORT, host + ":" + port)}")
```
I think all are fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
