panbingkun commented on code in PR #46057: URL: https://github.com/apache/spark/pull/46057#discussion_r1568360558
########## common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala: ########## @@ -63,83 +68,122 @@ object LogKey extends Enumeration { val CSV_SCHEMA_FIELD_NAME = Value val CSV_SCHEMA_FIELD_NAMES = Value val CSV_SOURCE = Value + val CURRENT_PATH = Value val DATA = Value val DATABASE_NAME = Value val DATAFRAME_CACHE_ENTRY = Value val DATAFRAME_ID = Value + val DATA_SOURCE = Value + val DATA_SOURCES = Value + val DATA_SOURCE_PROVIDER = Value + val DEFAULT_ISOLATION_LEVEL = Value + val DEFAULT_VALUE = Value + val DELEGATE = Value val DESCRIPTION = Value + val DESIRED_PARTITIONS_SIZE = Value val DRIVER_ID = Value val DROPPED_PARTITIONS = Value val DURATION = Value + val ELAPSED_TIME = Value + val ENCODING = Value + val END_INDEX = Value val END_POINT = Value val ENGINE = Value val ERROR = Value val EVENT_LOOP = Value val EVENT_QUEUE = Value val EXECUTE_INFO = Value val EXECUTE_KEY = Value + val EXECUTION_PLAN_LEAVES = Value val EXECUTOR_ENV_REGEX = Value val EXECUTOR_ID = Value val EXECUTOR_IDS = Value val EXECUTOR_STATE = Value val EXIT_CODE = Value - val EXPRESSION_TERMS = Value Review Comment: Let's unify it as an abbreviation `EXPRESSION` -> `EXPR` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org