uros-db commented on code in PR #46078:
URL: https://github.com/apache/spark/pull/46078#discussion_r1568630997
##########
sql/core/benchmarks/CollationBenchmark-results.txt:
##########
@@ -2,26 +2,53 @@ OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux
6.5.0-1017-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - equalsFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
--------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 7692 7731
55 0.0 76919.2 1.0X
-UNICODE 4378 4379
0 0.0 43784.6 1.8X
-UTF8_BINARY 4382 4396
19 0.0 43821.6 1.8X
-UNICODE_CI 48344 48360
23 0.0 483436.5 0.2X
+UTF8_BINARY_LCASE 7832 7837
7 0.0 78323.3 1.0X
+UNICODE 4369 4371
3 0.0 43685.5 1.8X
+UTF8_BINARY 4374 4374
0 0.0 43736.4 1.8X
+UNICODE_CI 48114 48156
60 0.0 481135.2 0.2X
OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1017-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - compareFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
---------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 9819 9820
0 0.0 98194.9 1.0X
-UNICODE 49507 49518
17 0.0 495066.2 0.2X
-UTF8_BINARY 7354 7365
17 0.0 73536.3 1.3X
-UNICODE_CI 52149 52163
20 0.0 521489.4 0.2X
+UTF8_BINARY_LCASE 8523 8525
3 0.0 85234.8 1.0X
+UNICODE 49150 49164
21 0.0 491496.8 0.2X
+UTF8_BINARY 7284 7290
8 0.0 72843.2 1.2X
+UNICODE_CI 50678 50723
64 0.0 506781.3 0.2X
OpenJDK 64-Bit Server VM 17.0.10+7-LTS on Linux 6.5.0-1017-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - hashFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 18110 18127
24 0.0 181103.9 1.0X
-UNICODE 171375 171435
85 0.0 1713752.3 0.1X
-UTF8_BINARY 14012 14030
26 0.0 140116.7 1.3X
-UNICODE_CI 153847 153901
76 0.0 1538471.1 0.1X
+UTF8_BINARY_LCASE 18144 18161
25 0.0 181435.4 1.0X
+UNICODE 174346 174406
85 0.0 1743455.7 0.1X
+UTF8_BINARY 13982 14006
35 0.0 139815.2 1.3X
+UNICODE_CI 146860 146972
159 0.0 1468595.2 0.1X
Review Comment:
I see that the benchmark runs on previous functions too, but we shouldn't
make any unnecessary modifications in this PR (that are not related to the
changes brought by this PR)
so I would advise keep the previous results as they were, and only append
yours below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
