vladimirg-db commented on code in PR #46078:
URL: https://github.com/apache/spark/pull/46078#discussion_r1568629092
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##########
@@ -36,18 +36,19 @@ abstract class CollationBenchmarkBase extends BenchmarkBase
{
utf8Strings.size * 10,
warmupTime = 10.seconds,
output = output)
- collationTypes.foreach(collationType => {
+ collationTypes.foreach { collationType => {
val collation = CollationFactory.fetchCollation(collationType)
benchmark.addCase(s"$collationType") { _ =>
- sublistStrings.foreach(s1 =>
- utf8Strings.foreach(s =>
- (0 to 10).foreach(_ =>
- collation.equalsFunction(s, s1).booleanValue())
- )
- )
+ sublistStrings.foreach { s1 =>
+ utf8Strings.foreach { s =>
+ (0 to 10).foreach { _ =>
+ collation.equalsFunction(s, s1).booleanValue()
+ }
+ }
+ }
}
}
- )
+ }
Review Comment:
Ah sorry, it was for the [HyukjinKwon](https://github.com/HyukjinKwon)'s
comment above. Do you think I should leave the old code like it was?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
