dongjoon-hyun commented on code in PR #46093:
URL: https://github.com/apache/spark/pull/46093#discussion_r1568970785
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -2182,4 +2183,13 @@ class JDBCSuite extends QueryTest with
SharedSparkSession {
dialect = JdbcDialects.get("jdbc:dummy:dummy_host:dummy_port/dummy_db")
assert(dialect === NoopDialect)
}
+
+ test("createTableColumnTypes") {
Review Comment:
Could you add a JIRA ID prefix?
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -2182,4 +2183,13 @@ class JDBCSuite extends QueryTest with
SharedSparkSession {
dialect = JdbcDialects.get("jdbc:dummy:dummy_host:dummy_port/dummy_db")
assert(dialect === NoopDialect)
}
+
+ test("createTableColumnTypes") {
+ val dialect =
JdbcDialects.get("jdbc:oracle:dummy_host:dummy_port/dummy_db")
+ val schema = new StructType().add("b", "boolean")
+ val schemaStr =
+ JdbcUtils.schemaString(dialect, schema, caseSensitive = false, Some("b
boolean"))
+ assert(schemaStr === """"b" NUMBER(1)""")
+
Review Comment:
nit, empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
