dongjoon-hyun commented on code in PR #46093:
URL: https://github.com/apache/spark/pull/46093#discussion_r1568974565
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -875,21 +875,20 @@ object JdbcUtils extends Logging with SQLConfHelper {
* Compute the schema string for this RDD.
*/
def schemaString(
+ dialect: JdbcDialect,
schema: StructType,
caseSensitive: Boolean,
- url: String,
createTableColumnTypes: Option[String] = None): String = {
val sb = new StringBuilder()
- val dialect = JdbcDialects.get(url)
val userSpecifiedColTypesMap = createTableColumnTypes
- .map(parseUserSpecifiedCreateTableColumnTypes(schema, caseSensitive, _))
+ .map(parseUserSpecifiedCreateTableColumnTypes(dialect, schema,
caseSensitive, _))
.getOrElse(Map.empty[String, String])
- schema.fields.foreach { field =>
+ schema.foreach { field =>
val name = dialect.quoteIdentifier(field.name)
val typ = userSpecifiedColTypesMap
.getOrElse(field.name, getJdbcType(field.dataType,
dialect).databaseTypeDefinition)
- val nullable = if (field.nullable) "" else "NOT NULL"
- sb.append(s", $name $typ $nullable")
+ val nullable = if (field.nullable) "" else " NOT NULL"
+ sb.append(s", $name $typ$nullable")
Review Comment:
Please revert this two irrelevant lines.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -875,21 +875,20 @@ object JdbcUtils extends Logging with SQLConfHelper {
* Compute the schema string for this RDD.
*/
def schemaString(
+ dialect: JdbcDialect,
schema: StructType,
caseSensitive: Boolean,
- url: String,
createTableColumnTypes: Option[String] = None): String = {
val sb = new StringBuilder()
- val dialect = JdbcDialects.get(url)
val userSpecifiedColTypesMap = createTableColumnTypes
- .map(parseUserSpecifiedCreateTableColumnTypes(schema, caseSensitive, _))
+ .map(parseUserSpecifiedCreateTableColumnTypes(dialect, schema,
caseSensitive, _))
.getOrElse(Map.empty[String, String])
- schema.fields.foreach { field =>
+ schema.foreach { field =>
val name = dialect.quoteIdentifier(field.name)
val typ = userSpecifiedColTypesMap
.getOrElse(field.name, getJdbcType(field.dataType,
dialect).databaseTypeDefinition)
- val nullable = if (field.nullable) "" else "NOT NULL"
- sb.append(s", $name $typ $nullable")
+ val nullable = if (field.nullable) "" else " NOT NULL"
+ sb.append(s", $name $typ$nullable")
Review Comment:
Please revert these two irrelevant lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
